Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update docker to v26 #1146

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

matejvasek
Copy link
Contributor

@matejvasek matejvasek commented Jun 4, 2024

  • Updated docker dep v25 => v26
  • Removed usage of deprecated github.com/docker/distribution/reference package.

@openshift-ci openshift-ci bot requested review from apoorvajagtap and jkhelil June 4, 2024 05:51
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek matejvasek force-pushed the update-docker-v26 branch from b2bc454 to 3f004e2 Compare June 4, 2024 06:04
@matejvasek
Copy link
Contributor Author

cc @coreydaley

@matejvasek
Copy link
Contributor Author

cc @adambkaplan

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek matejvasek force-pushed the update-docker-v26 branch from a5ace19 to e24d63b Compare June 4, 2024 07:57
Copy link
Contributor

openshift-ci bot commented Jun 4, 2024

@matejvasek: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security e24d63b link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -4,8 +4,8 @@ go 1.20

require (
github.com/containers/image/v5 v5.29.0
github.com/docker/distribution v2.8.3+incompatible
github.com/docker/docker v25.0.3+incompatible
github.com/distribution/reference v0.5.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to docker/distribution moving to the CNCF! 🎉

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f94ff35 into openshift:master Jun 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants