Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue][TF FE]: Support Inv operation for TensorFlow models #20619

Closed
rkazants opened this issue Oct 19, 2023 · 3 comments · Fixed by #20720
Closed

[Good First Issue][TF FE]: Support Inv operation for TensorFlow models #20619

rkazants opened this issue Oct 19, 2023 · 3 comments · Fixed by #20720
Assignees
Labels
category: TF FE OpenVINO TensorFlow FrontEnd good first issue Good for newcomers no_stale Do not mark as stale
Milestone

Comments

@rkazants
Copy link
Member

rkazants commented Oct 19, 2023

Context

OpenVINO component responsible for support of TensorFlow models is called as TensorFlow Frontend (TF FE). TF FE converts a model represented in TensorFlow opset to a model in OpenVINO opset.

In order to infer TensorFlow models with Inv operation by OpenVINO, TF FE needs to be extended with this operation support.

What needs to be done?

For Inv operation support, you need to add the corresponding loader into TF FE op directory and to register it into the dictionary of Loaders. One loader is responsible for conversion (or decomposition) of one type of TensorFlow operation.

Here is an example of loader implementation for TensorFlow Einsum operation:

OutputVector translate_einsum_op(const NodeContext& node) { 
     auto op_type = node.get_op_type(); 
     TENSORFLOW_OP_VALIDATION(node, op_type == "Einsum", "Internal error: incorrect usage of translate_einsum_op."); 
     auto equation = node.get_attribute<std::string>("equation"); 
  
     OutputVector inputs; 
     for (size_t input_ind = 0; input_ind < node.get_input_size(); ++input_ind) { 
         inputs.push_back(node.get_input(input_ind)); 
     } 
  
     auto einsum = make_shared<Einsum>(inputs, equation); 
     set_node_name(node.get_name(), einsum); 
     return {einsum}; 
 } 

In this example, translate_einsum_op converts TF Einsum into OV Einsum. NodeContext object passed into the loader packs all info about inputs and attributes of Einsum operation. The loader retrieves an attribute of the equation by using the NodeContext::get_attribute() method, prepares input vector, creates Einsum operation from OV opset and returns a vector of outputs.

Responsibility of a loader is to parse operation attributes, prepare inputs and express TF operation via OV operations sub-graph. Example for Einsum demonstrates the resulted sub-graph with one operation. In PR #19007 you can see operation decomposition into multiple node sub-graph.

Hint

Super simple operation. Just create Constant 1 of the same type as x and apply division. 😃

Example Pull Requests

Resources

Contact points

@openvinotoolkit/openvino-tf-frontend-maintainers

Ticket

TBD

@rkazants rkazants added good first issue Good for newcomers no_stale Do not mark as stale labels Oct 19, 2023
@rkazants rkazants moved this to Contributors Needed in Good first issues Oct 19, 2023
@rkazants rkazants added the category: TF FE OpenVINO TensorFlow FrontEnd label Oct 19, 2023
@rkazants rkazants moved this to Contributors Needed in OpenVINO General Board Oct 21, 2023
@rkazants rkazants changed the title [Good First Issue]: Support Inv operation for TensorFlow models [Good First Issue][TF FE]: Support Inv operation for TensorFlow models Oct 21, 2023
@rkazants rkazants moved this from Contributors Needed to Assigned in OpenVINO General Board Oct 24, 2023
@rkazants rkazants moved this from Assigned to Contributors Needed in OpenVINO General Board Oct 24, 2023
@mlukasze
Copy link
Contributor

hey @rsato10
now you can assign tickets by yourself, check last part of this instruction for details:
#17502

@rsato10
Copy link
Contributor

rsato10 commented Oct 26, 2023

.take

@github-actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki p-wysocki moved this from Contributors Needed to In Review in Good first issues Oct 27, 2023
@rkazants rkazants moved this from Contributors Needed to Assigned in OpenVINO General Board Oct 28, 2023
@rkazants rkazants moved this from Assigned to Under Review in OpenVINO General Board Oct 28, 2023
@ilya-lavrenov ilya-lavrenov added this to the 2023.2 milestone Oct 31, 2023
@ilya-lavrenov ilya-lavrenov moved this from In Review to Closed in Good first issues Oct 31, 2023
@ilya-lavrenov ilya-lavrenov moved this from Under Review to Closed in OpenVINO General Board Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: TF FE OpenVINO TensorFlow FrontEnd good first issue Good for newcomers no_stale Do not mark as stale
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants