Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TF FE] Support ToBool operation #20511

Merged
merged 21 commits into from
Oct 20, 2023
Merged

[TF FE] Support ToBool operation #20511

merged 21 commits into from
Oct 20, 2023

Conversation

rsato10
Copy link
Contributor

@rsato10 rsato10 commented Oct 17, 2023

Details:

Tickets:

  • TBD

@rsato10 rsato10 requested a review from a team as a code owner October 17, 2023 09:23
@github-actions github-actions bot added category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd labels Oct 17, 2023
@rkazants rkazants self-assigned this Oct 17, 2023
@rkazants rkazants changed the title Rsato10/tobool tf [TF FE] Support ToBool operation Oct 17, 2023
@rkazants
Copy link
Member

build_jenkins

@rkazants rkazants linked an issue Oct 17, 2023 that may be closed by this pull request
[Good First Issue]: Support ToBool operation for TensorFlow models #20496
Closed
@rkazants rkazants added this to the 2023.2 milestone Oct 17, 2023
@rkazants
Copy link
Member

build_jenkins

@rkazants rkazants added the ExternalPR External contributor label Oct 17, 2023
@rkazants
Copy link
Member

build_jenkins

@rkazants rkazants self-requested a review October 18, 2023 11:37
@rkazants
Copy link
Member

rkazants commented Oct 19, 2023 •
edited
Loading

@rsato10, please do not forget about code-style next time. You can apply clang formatting in your IDE automatically or by other way.

@rsato10
Copy link
Contributor Author

rsato10 commented Oct 19, 2023

@rsato10, please do not forget about code-style next time. You can apply clang formatting in your IDE automatically or by other way.

Sorry, Ill use the clang formatting in the future

@rkazants
Copy link
Member

build_jenkins

@rkazants
Copy link
Member

@ilya-lavrenov, looks we are for merge:)

@ilya-lavrenov ilya-lavrenov merged commit 9edbcb1 into openvinotoolkit:master Oct 20, 2023
@rkazants
Copy link
Member

rkazants commented Oct 20, 2023 •
edited
Loading

@rsato10, congratulations with your first PR merged to OpenVINO!
Feel free to take new good first issues for TensorFlow Frontend:

alvoron pushed a commit to alvoron/openvino that referenced this pull request Nov 6, 2023
@rsato10 @rkazants @alvoron
[TF FE] Support ToBool operation (openvinotoolkit#20511)
2f6d85b 
* [TF FE][TF Hub] Support ToBool operations

* [TF FE][TF Hub] Support ToBool operations

* fixing select operation Support ToBool operations for TF Hub models

* added false and true const for tobool operations

* added reduction axes

* Apply suggestions from code review

* Update tests/layer_tests/tensorflow_tests/test_tf_ToBool.py

* Update tests/layer_tests/tensorflow_tests/test_tf_ToBool.py

* Update tests/layer_tests/tensorflow_tests/test_tf_ToBool.py

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

* added second zero constant

* added correct types  src\frontends\tensorflow_common\src\op\tobool.cpp

* added includes src\frontends\tensorflow_common\src\op\tobool.cpp

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

* remove select and not_equal src/frontends/tensorflow_common/src/op/tobool.cpp

* Apply suggestions from code review

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

* Apply suggestions from code review

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

---------

Co-authored-by: Roman Kazantsev <roman.kazantsev@intel.com>
allnes pushed a commit to allnes/openvino that referenced this pull request Nov 23, 2023
@rsato10 @rkazants @allnes
[TF FE] Support ToBool operation (openvinotoolkit#20511)
b3c848b 
* [TF FE][TF Hub] Support ToBool operations

* [TF FE][TF Hub] Support ToBool operations

* fixing select operation Support ToBool operations for TF Hub models

* added false and true const for tobool operations

* added reduction axes

* Apply suggestions from code review

* Update tests/layer_tests/tensorflow_tests/test_tf_ToBool.py

* Update tests/layer_tests/tensorflow_tests/test_tf_ToBool.py

* Update tests/layer_tests/tensorflow_tests/test_tf_ToBool.py

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

* added second zero constant

* added correct types  src\frontends\tensorflow_common\src\op\tobool.cpp

* added includes src\frontends\tensorflow_common\src\op\tobool.cpp

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

* remove select and not_equal src/frontends/tensorflow_common/src/op/tobool.cpp

* Apply suggestions from code review

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

* Apply suggestions from code review

* Update src/frontends/tensorflow_common/src/op/tobool.cpp

---------

Co-authored-by: Roman Kazantsev <roman.kazantsev@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkazants rkazants rkazants approved these changes

Assignees

@rkazants rkazants

Labels
category: TF FE OpenVINO TensorFlow FrontEnd category: TFL FE OpenVINO TensorFlow Lite FrontEnd ExternalPR External contributor
Projects
None yet
Milestone
2023.2
Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Support ToBool operation for TensorFlow models
3 participants
@rsato10 @rkazants @ilya-lavrenov