Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to get a computation's caller(s). #23681

Closed
wants to merge 1 commit into from

Conversation

jreiffers
Copy link
Contributor

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.
@jreiffers
Copy link
Contributor Author

@akuegel As discussed. I optimized this a bit for the common case (just a single caller). Seemed to be in the spirit of the instruction_and_type_ field.

Copy link
Member

@akuegel akuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

copybara-service bot pushed a commit that referenced this pull request Mar 13, 2025
Imported from GitHub PR #23681

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.
Copybara import of the project:

--
4168abb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Add an API to get a computation's caller(s).

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.

Merging this change closes #23681

FUTURE_COPYBARA_INTEGRATE_REVIEW=#23681 from jreiffers:caller-instructions 4168abb
PiperOrigin-RevId: 736448470
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 13, 2025
Imported from GitHub PR openxla/xla#23681

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.
Copybara import of the project:

--
4168abbcd70640eaa0b4a28b9add6cbfb1482470 by Johannes Reifferscheid <jreiffers@nvidia.com>:

Add an API to get a computation's caller(s).

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.

Merging this change closes #23681

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#23681 from jreiffers:caller-instructions 4168abbcd70640eaa0b4a28b9add6cbfb1482470
PiperOrigin-RevId: 736448470
copybara-service bot pushed a commit that referenced this pull request Mar 13, 2025
Imported from GitHub PR #23681

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.
Copybara import of the project:

--
4168abb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Add an API to get a computation's caller(s).

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.

Merging this change closes #23681

FUTURE_COPYBARA_INTEGRATE_REVIEW=#23681 from jreiffers:caller-instructions 4168abb
PiperOrigin-RevId: 736448470
copybara-service bot pushed a commit that referenced this pull request Mar 13, 2025
Imported from GitHub PR #23681

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.
Copybara import of the project:

--
4168abb by Johannes Reifferscheid <jreiffers@nvidia.com>:

Add an API to get a computation's caller(s).

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.

Merging this change closes #23681

FUTURE_COPYBARA_INTEGRATE_REVIEW=#23681 from jreiffers:caller-instructions 4168abb
PiperOrigin-RevId: 736448470
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 13, 2025
Imported from GitHub PR openxla/xla#23681

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.
Copybara import of the project:

--
4168abbcd70640eaa0b4a28b9add6cbfb1482470 by Johannes Reifferscheid <jreiffers@nvidia.com>:

Add an API to get a computation's caller(s).

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.

Merging this change closes #23681

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#23681 from jreiffers:caller-instructions 4168abbcd70640eaa0b4a28b9add6cbfb1482470
PiperOrigin-RevId: 736448470
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Mar 13, 2025
Imported from GitHub PR openxla/xla#23681

This should replace CallGraph in most cases, and adds an alternative to the deprecated .*CallInstruction functions.
Copybara import of the project:

--
4168abbcd70640eaa0b4a28b9add6cbfb1482470 by Johannes Reifferscheid <jreiffers@nvidia.com>:

Add an API to get a computation's caller(s).

This should replace CallGraph in most cases, and adds an alternative to
the deprecated .*CallInstruction functions.

Merging this change closes #23681

PiperOrigin-RevId: 736473711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants