Add server build, module build and bump upstream versions #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <classifier>module</classifier> | ||
| <!-- https://github.com/spring-projects/spring-boot/issues/3426 transitive exclude doesn't work --> | ||
| <excludeGroupIds>io.zipkin.java,org.springframework.boot,org.springframework,commons-codec,com.fasterxml.jackson.core,com.fasterxml.jackson.dataformat,org.apache.httpcomponents,commons-logging,joda-time,software.amazon.ion</excludeGroupIds> | ||
| <!-- already packaged in zipkin-server --> |
There was a problem hiding this comment.
no action needed: at some point, I'd like to migrate the elasticsearch-aws stuff here, and then we'd no longer need this exclude
|
merging knowing we haven't documented, yet. This is OK as we haven't tested it via docker, and whatever layer instructions end up best will end up what we need to circle-back and document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied module build config from here: openzipkin/zipkin#1219. Besides building things and reviewing the contents of the module JAR I haven't actually tested it any further. Once the snapshots are deployed I can setup a Docker build as described in the ticket and test it out end to end.