Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(svi): add few more mock tests #163

Merged
merged 1 commit into from
Sep 6, 2023
Merged

test(svi): add few more mock tests #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
129 changes: 128 additions & 1 deletion pkg/evpn/svi_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ func Test_CreateSvi(t *testing.T) {
exist: false,
on: nil,
},
"failed LinkByName call": {
"failed bridge LinkByName call": {
id: testSviID,
in: &testSvi,
out: nil,
Expand Down Expand Up @@ -258,6 +258,133 @@ func Test_CreateSvi(t *testing.T) {
mockNetlink.EXPECT().LinkSetHardwareAddr(vlandev, mac).Return(errors.New(errMsg)).Once()
},
},
"failed AddrAdd call": {
id: testSviID,
in: &testSvi,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call AddrAdd",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
vid := uint16(testLogicalBridge.Spec.VlanId)
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
mockNetlink.EXPECT().BridgeVlanAdd(bridge, vid, false, false, true, false).Return(nil).Once()
vlanName := fmt.Sprintf("vlan%d", vid)
vlandev := &netlink.Vlan{LinkAttrs: netlink.LinkAttrs{Name: vlanName, ParentIndex: bridge.Attrs().Index}, VlanId: int(vid)}
mockNetlink.EXPECT().LinkAdd(vlandev).Return(nil).Once()
mac := net.HardwareAddr(testSvi.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(vlandev, mac).Return(nil).Once()
myip := make(net.IP, 4)
addr := &netlink.Addr{IPNet: &net.IPNet{IP: myip, Mask: net.CIDRMask(24, 32)}}
mockNetlink.EXPECT().AddrAdd(vlandev, addr).Return(errors.New(errMsg)).Once()
},
},
"failed LinkByName call": {
id: testSviID,
in: &testSvi,
out: nil,
errCode: codes.NotFound,
errMsg: fmt.Sprintf("unable to find key %v", testVrfName),
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
vid := uint16(testLogicalBridge.Spec.VlanId)
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
mockNetlink.EXPECT().BridgeVlanAdd(bridge, vid, false, false, true, false).Return(nil).Once()
vlanName := fmt.Sprintf("vlan%d", vid)
vlandev := &netlink.Vlan{LinkAttrs: netlink.LinkAttrs{Name: vlanName, ParentIndex: bridge.Attrs().Index}, VlanId: int(vid)}
mockNetlink.EXPECT().LinkAdd(vlandev).Return(nil).Once()
mac := net.HardwareAddr(testSvi.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(vlandev, mac).Return(nil).Once()
myip := make(net.IP, 4)
addr := &netlink.Addr{IPNet: &net.IPNet{IP: myip, Mask: net.CIDRMask(24, 32)}}
mockNetlink.EXPECT().AddrAdd(vlandev, addr).Return(nil).Once()
mockNetlink.EXPECT().LinkByName(testVrfID).Return(nil, errors.New(errMsg)).Once()
},
},
"failed LinkSetMaster call": {
id: testSviID,
in: &testSvi,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call LinkSetMaster",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
vid := uint16(testLogicalBridge.Spec.VlanId)
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
mockNetlink.EXPECT().BridgeVlanAdd(bridge, vid, false, false, true, false).Return(nil).Once()
vlanName := fmt.Sprintf("vlan%d", vid)
vlandev := &netlink.Vlan{LinkAttrs: netlink.LinkAttrs{Name: vlanName, ParentIndex: bridge.Attrs().Index}, VlanId: int(vid)}
mockNetlink.EXPECT().LinkAdd(vlandev).Return(nil).Once()
mac := net.HardwareAddr(testSvi.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(vlandev, mac).Return(nil).Once()
myip := make(net.IP, 4)
addr := &netlink.Addr{IPNet: &net.IPNet{IP: myip, Mask: net.CIDRMask(24, 32)}}
mockNetlink.EXPECT().AddrAdd(vlandev, addr).Return(nil).Once()
vrfdev := &netlink.Vrf{LinkAttrs: netlink.LinkAttrs{Name: testVrfID}, Table: 1001}
mockNetlink.EXPECT().LinkByName(testVrfID).Return(vrfdev, nil).Once()
mockNetlink.EXPECT().LinkSetMaster(vlandev, vrfdev).Return(errors.New(errMsg)).Once()
},
},
"failed LinkSetUp call": {
id: testSviID,
in: &testSvi,
out: nil,
errCode: codes.Unknown,
errMsg: "Failed to call LinkSetUp",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
vid := uint16(testLogicalBridge.Spec.VlanId)
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
mockNetlink.EXPECT().BridgeVlanAdd(bridge, vid, false, false, true, false).Return(nil).Once()
vlanName := fmt.Sprintf("vlan%d", vid)
vlandev := &netlink.Vlan{LinkAttrs: netlink.LinkAttrs{Name: vlanName, ParentIndex: bridge.Attrs().Index}, VlanId: int(vid)}
mockNetlink.EXPECT().LinkAdd(vlandev).Return(nil).Once()
mac := net.HardwareAddr(testSvi.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(vlandev, mac).Return(nil).Once()
myip := make(net.IP, 4)
addr := &netlink.Addr{IPNet: &net.IPNet{IP: myip, Mask: net.CIDRMask(24, 32)}}
mockNetlink.EXPECT().AddrAdd(vlandev, addr).Return(nil).Once()
vrfdev := &netlink.Vrf{LinkAttrs: netlink.LinkAttrs{Name: testVrfID}, Table: 1001}
mockNetlink.EXPECT().LinkByName(testVrfID).Return(vrfdev, nil).Once()
mockNetlink.EXPECT().LinkSetMaster(vlandev, vrfdev).Return(nil).Once()
mockNetlink.EXPECT().LinkSetUp(vlandev).Return(errors.New(errMsg)).Once()
},
},
"successful call": {
id: testSviID,
in: &testSvi,
out: &pb.Svi{
Spec: testSvi.Spec,
Status: &pb.SviStatus{
OperStatus: pb.SVIOperStatus_SVI_OPER_STATUS_UP,
},
},
errCode: codes.OK,
errMsg: "",
exist: false,
on: func(mockNetlink *mocks.Netlink, errMsg string) {
vid := uint16(testLogicalBridge.Spec.VlanId)
bridge := &netlink.Bridge{LinkAttrs: netlink.LinkAttrs{Name: tenantbridgeName}}
mockNetlink.EXPECT().LinkByName(tenantbridgeName).Return(bridge, nil).Once()
mockNetlink.EXPECT().BridgeVlanAdd(bridge, vid, false, false, true, false).Return(nil).Once()
vlanName := fmt.Sprintf("vlan%d", vid)
vlandev := &netlink.Vlan{LinkAttrs: netlink.LinkAttrs{Name: vlanName, ParentIndex: bridge.Attrs().Index}, VlanId: int(vid)}
mockNetlink.EXPECT().LinkAdd(vlandev).Return(nil).Once()
mac := net.HardwareAddr(testSvi.Spec.MacAddress[:])
mockNetlink.EXPECT().LinkSetHardwareAddr(vlandev, mac).Return(nil).Once()
myip := make(net.IP, 4)
addr := &netlink.Addr{IPNet: &net.IPNet{IP: myip, Mask: net.CIDRMask(24, 32)}}
mockNetlink.EXPECT().AddrAdd(vlandev, addr).Return(nil).Once()
vrfdev := &netlink.Vrf{LinkAttrs: netlink.LinkAttrs{Name: testVrfID}, Table: 1001}
mockNetlink.EXPECT().LinkByName(testVrfID).Return(vrfdev, nil).Once()
mockNetlink.EXPECT().LinkSetMaster(vlandev, vrfdev).Return(nil).Once()
mockNetlink.EXPECT().LinkSetUp(vlandev).Return(nil).Once()
},
},
}

// run tests
Expand Down