Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable keyboard navigation in resource browser #2572

Closed
FlorianSchepers opened this issue Feb 14, 2024 · 0 comments · Fixed by #2591
Closed

Enable keyboard navigation in resource browser #2572

FlorianSchepers opened this issue Feb 14, 2024 · 0 comments · Fixed by #2591
Assignees
@MarkusObendrauf

Comments

@FlorianSchepers
Copy link
Member

FlorianSchepers commented Feb 14, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently, navigating the resource tree requires the users to click on each resource to expand/collapse.
For the user that implies the need to click a lot.

Navigation:

  • up-down navigation with arrows
  • use horizontal navigation to expand/collapse leaves
  • experiment if it's better to select the item with space or if an item should be immediately selected after the navigation event

Describe the solution you'd like
As a user navigating in the file tree in resource view, I want to be able to use keyboard navigation.

is blocked by #971
mstykow added a commit that referenced this issue Mar 5, 2024
@mstykow
feat: add keyboard navigation for resource tree

Verified

This commit was signed with the committer’s verified signature.
snyk-bot Snyk bot
GPG key ID: 5009E0832F4D3DD3
Verified
Learn about vigilant mode
Loading
Loading status checks…
3be3c17 
- keep track of focused ID instead of focused index in Virtuoso
- add focus state for tree nodes and define keyboard actions

closes #2572

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow mentioned this issue Mar 5, 2024
Merged
@mstykow mstykow linked a pull request Mar 5, 2024 that will close this issue
feat: add keyboard navigation for resource tree #2591
Merged
mstykow added a commit that referenced this issue Mar 5, 2024
@mstykow
feat: add keyboard navigation for resource tree
Loading
Loading status checks…
c65d5e0 
- keep track of focused ID instead of focused index in Virtuoso
- add focus state for tree nodes and define keyboard actions

closes #2572

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 6, 2024
@mstykow
feat: add keyboard navigation for resource tree
Loading
Loading status checks…
6deb431 
- keep track of focused ID instead of focused index in Virtuoso
- add focus state for tree nodes and define keyboard actions

closes #2572

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
MarkusObendrauf pushed a commit that referenced this issue Mar 6, 2024
@mstykow @MarkusObendrauf
feat: add keyboard navigation for resource tree
Loading
Loading status checks…
63b4d7e 
- keep track of focused ID instead of focused index in Virtuoso
- add focus state for tree nodes and define keyboard actions

closes #2572

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
MarkusObendrauf pushed a commit that referenced this issue Mar 6, 2024
@mstykow @MarkusObendrauf
feat: add keyboard navigation for resource tree
Loading
Loading status checks…
a8ded4b 
- keep track of focused ID instead of focused index in Virtuoso
- add focus state for tree nodes and define keyboard actions

closes #2572

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
Signed-off-by: Markus Obendrauf <markus.obendrauf@tngtech.com>
MarkusObendrauf pushed a commit that referenced this issue Mar 6, 2024
@mstykow @MarkusObendrauf
feat: add keyboard navigation for resource tree
Loading
Loading status checks…
05aa69a 
- keep track of focused ID instead of focused index in Virtuoso
- add focus state for tree nodes and define keyboard actions

closes #2572

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
Signed-off-by: Markus Obendrauf <markus.obendrauf@tngtech.com>
@mstykow mstykow closed this as completed in 91bf5fa Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkusObendrauf MarkusObendrauf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add keyboard navigation for resource tree opossum-tool/OpossumUI
2 participants
@FlorianSchepers @MarkusObendrauf