Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce "cmd+f" shortcut for quick search of resources #2587

Closed
FlorianSchepers opened this issue Feb 29, 2024 · 1 comment · Fixed by #2594
Closed

Reintroduce "cmd+f" shortcut for quick search of resources #2587

FlorianSchepers opened this issue Feb 29, 2024 · 1 comment · Fixed by #2594
Assignees
@mstykow

Comments

@FlorianSchepers
Copy link
Member

Is your feature request related to a problem? Please describe.
In previous version of OpossumUI the user had the option to use the shortcut "cmd+f" to open the search for resources. With the update to OpossumUI 2.0 this feature was removed. It would be helpful to bring the feature back.

Describe the solution you'd like
Reintroduce the shortcut "cmd+f". When executed the resource search should be opened.

Describe alternatives you've considered
It was considered to open either the resoruce, attribution or signal search when "cmd+f" is pressed, dependeing on which element was selected most recently, i.e., a resource, an attribution or a signal, respectively. We decided against this option as it would makes to shortcut functionallity more complex and might lead to confusion by the user.

Additional context
This is a feature request for OpossumUI 2.0
@mstykow
Copy link
Member

mstykow commented Mar 4, 2024

Two ideas:

  1. cmd+f only searches the items in the currently focused list. so if i'm looking at an attribution, it would search the attributions etc.
  2. introduce one search shortcut for each list.

@mstykow mstykow self-assigned this Mar 6, 2024
mstykow added a commit that referenced this issue Mar 6, 2024
@mstykow
feat: search by shortcut
800cdee 
- introduce ctrl/cmd+f shortcut to search for resources, attributions, signals depending on the focused context
- use React context for search-ref because Redux can only handle serializable data
- use context for Virtuoso comp. props as they cannot be inlined: petyosi/react-virtuoso#566

closes #2587

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
@mstykow mstykow mentioned this issue Mar 6, 2024
Merged
mstykow added a commit that referenced this issue Mar 6, 2024
@mstykow
feat: search by shortcut
39a611d 
- introduce ctrl/cmd+f shortcut to search for resources, attributions, signals depending on the focused context
- use React context for search-ref because Redux can only handle serializable data
- use context for Virtuoso comp. props as they cannot be inlined: petyosi/react-virtuoso#566

closes #2587

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 7, 2024
@mstykow
feat: search by shortcut
d2a8a4e 
- introduce ctrl/cmd+f shortcut to search for resources, attributions, signals depending on the focused context
- use React context for search-ref because Redux can only handle serializable data
- use context for Virtuoso comp. props as they cannot be inlined: petyosi/react-virtuoso#566

closes #2587

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 7, 2024
@mstykow
feat: search by shortcut
92f68af 
- add four global hotkeys for accessing the four different searches
- introduce ctrl/cmd+f shortcut to search for resources, attributions, signals depending on the focused context
- improve general keyboard accessibility
- use React context for search-ref because Redux can only handle serializable data
- use context for Virtuoso comp. props as they cannot be inlined: petyosi/react-virtuoso#566

closes #2587

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 7, 2024
@mstykow
feat: search by shortcut
d74b0f0 
- add four global hotkeys for accessing the four different searches
- introduce ctrl/cmd+f shortcut to search for resources, attributions, signals depending on the focused context
- improve general keyboard accessibility
- use React context for search-ref because Redux can only handle serializable data
- use context for Virtuoso comp. props as they cannot be inlined: petyosi/react-virtuoso#566

closes #2587

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow added a commit that referenced this issue Mar 7, 2024
@mstykow
feat: search by shortcut
4daded9 
- add four global hotkeys for accessing the four different searches
- introduce ctrl/cmd+f shortcut to search for resources, attributions, signals depending on the focused context
- improve general keyboard accessibility
- use React context for search-ref because Redux can only handle serializable data
- use context for Virtuoso comp. props as they cannot be inlined: petyosi/react-virtuoso#566

closes #2587

Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mstykow mstykow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: search by shortcut opossum-tool/OpossumUI
2 participants
@mstykow @FlorianSchepers