Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribution Wizard: Documentation #1379

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

lennartclaas
Copy link
Member

Add section about attribution wizard to USER_GUIDE.md.

Some minor changes in USER_GUIDE.md to reduce oversized images.

Fix: #1299

Copy link
Contributor

@vasily-pozdnyakov vasily-pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to update the last three screenshots.

USER_GUIDE.md Outdated
` ... in folder content` sub-panels also show the number of resources in the folder that are linked to the shown
attribution.

The `Add to Attribution Sub-Panel` allows to add an existing attribution to the attributions of the selected resource.
As in the other panels, the details of the attributions can be shown by clicking on the respective list item, while the
attribution can be added by clicking on the corresponding **+ icon**.

###### Attribution Wizard
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have a bigger font size.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, however, in a logical sense, Attribution Wizard must be a subsection of Attribution Selection Column, hence it needs one hash more. But if no one has arguments against using one hash less, I can do it. I agree that is would look nicer this way.

- Path of the selected resource (1).
- Breadcrumbs for navigation (2). Each breadcrumb corresponds to a step of the wizard.
- Package URL (3) that reflects the currently selected package attributes.
- Lists of aggregated package attributes (4), e.g., package namespace, name, and version (depending on wizard step).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comma after "e.g."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends whether we want to use british (without comma after e.g.) oder american style (with comma after e.g.). I would prefer the american style.

USER_GUIDE.md Outdated

<img src="./docs/user_guide_screenshots/attribution_wizard_doc_overview.png" width="550"/>

In the first step, package namespace and name can be selected. The list entries are sorted by count, i.e., the number of occurrences in the attributions and signals of the current resource and its descendents. New list entries can be added manually via the textboxes below the lists (5). New list items are marked with a star-icon and are displayed at the top of the list (6).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no comma after "i.e."
Propose: "New list items are marked"-> "Manually added items are marked..."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding i.e.: see above.

The proposal is good. I will consider it.

@vasily-pozdnyakov vasily-pozdnyakov self-assigned this Feb 2, 2023
@lennartclaas
Copy link
Member Author

lennartclaas commented Feb 6, 2023

@vasily-pozdnyakov regarding your comment:

What do you mean by that? The last three screenshots are about the attribution wizard, attribution view, and report view. Do you mean updating the last two images because the corresponding appearances in the UI hast changed?

@lennartclaas : yes, the UI has changed.

@lennartclaas
Copy link
Member Author

lennartclaas commented Feb 6, 2023

I created a new ticket for updating other images in USER_GUIDE.md #1384

Copy link
Member

@benedikt-richter benedikt-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice documentation! Just added two suggestions.

I worry a bit about the images as these will have to be updated repeatedly (including manually adding the respective numbers (that are displayed in red)).

USER_GUIDE.md Outdated
` ... in folder content` sub-panels also show the number of resources in the folder that are linked to the shown
attribution.

The `Add to Attribution Sub-Panel` allows to add an existing attribution to the attributions of the selected resource.
As in the other panels, the details of the attributions can be shown by clicking on the respective list item, while the
attribution can be added by clicking on the corresponding **+ icon**.

##### Attribution Wizard

The `Attribution Wizard` can be opened via the context menu of an assigned attribution. It aggregates information from attributions and signals of the current resource and its descendents and provides a structured overview. By clicking through the wizard, package namespace, name, and version can be selected and saved to the `Attribution Details Column` of the attribution from which the wizard has been opened.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd replace the context menu of an assigned attribution by the context menu of a manual attribution.

USER_GUIDE.md Outdated

- Path of the selected resource (1).
- Breadcrumbs for navigation (2). Each breadcrumb corresponds to a step of the wizard.
- Package URL (3) that reflects the currently selected package attributes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that reflects the currently selected package attributes. -> that describes the currently selected package.

Add section about attribution wizard to USER_GUIDE.md.

Fix: opossum-tool#1299

Signed-off-by: Lennart Holstein <lennart.holstein@tngtech.com>
@lennartclaas lennartclaas merged commit 8a16695 into opossum-tool:main Feb 6, 2023
@lennartclaas lennartclaas deleted the wizard-doc branch February 7, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1275] Document new feature
3 participants