Adapt PackageInfo conversion functions and rename temporaryPackageInfo
#1661
+960
−766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functions for converting PackageInfo to DisplayPackageInfo and vice versa are changed to get rid of the large switch blocks. Additionally, tests are added that ensure that newly added fields to PackageInfo and DisplayPackageInfo are taken into account. Signed-off-by: Lennart Holstein <lennart.holstein@tngtech.com>
lennartclaas
changed the title
PackageInfo conversion functions and rename temporaryPackageInfo
benedikt-richter
approved these changes
May 8, 2023
'temporaryDisplayPackageInfo'. This is part of the 'DisplayPackageInfo' refactoring. Signed-off-by: Lennart Holstein <lennart.holstein@tngtech.com>
lennartclaas
force-pushed
the
refactoring-4.5
branch
from
97229fb to
150cfae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
temporaryPackageInfototemporaryDisplayPackageInfo.Context and reason for change
Part of the
DisplayPackageInforefactoring to improve separation between business and display logic.Fix: #1659