Resource icon is grey after deletion of all manual attribution #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix opossum-tool#1685 Signed-off-by: Vasily Pozdnyakov <vasily.pozdnyakov@tngtech.com>
vasily-pozdnyakov
force-pushed
the
fix_1685
branch
from
5d3f345 to
12d7285
Compare
|
Added tests and realized that it is not python ('in' does not work for arrays in js) :) |
benedikt-richter
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
resourcesWithManualAttributedChildren.pathToIndices is not updated once attribution is deleted. Paths is the correct list which is updated.
Context and reason for change
Fix #1685
How can the changes be tested
Start the app, find any resource without attributions (resource with grey icon), create a new attribution for the resource, delete it and check the color of resource icon (it has to be in the same state as it was at the beginning - grey)