Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix report view table #1928

Merged

Conversation

benedikt-richter
Copy link
Member

Summary of changes

Decrease max height of table.

Context and reason for change

Fix: #1927

How can the changes be tested

Before:
Screenshot 2023-09-06 at 12 44 23

Now:
Screenshot 2023-09-06 at 12 48 59

Decrease max height of table.

Fix: opossum-tool#1927

Signed-off-by: Benedikt Richter <benedikt.richter@tngtech.com>
Copy link
Member

@maxhbr maxhbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -100,7 +100,7 @@ interface TableProps {
}

export function Table(props: TableProps): ReactElement | null {
const tableHeaderOffset = 110;
const tableHeaderOffset = 145;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good

@benedikt-richter benedikt-richter merged commit b47b875 into opossum-tool:main Sep 6, 2023
@benedikt-richter benedikt-richter deleted the fix_report_view branch September 6, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table in report view has no horizontal scroll bar
2 participants