Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocatorPopup to find signals #1949

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

meretp
Copy link
Contributor

@meretp meretp commented Sep 8, 2023

Summary of changes

This diff adds the skeleton for a locator popup.

Context and reason for change

We want to introduce a new feature which enables the user to search for signals based on criticality and licenses.

How can the changes be tested

See the unit tests. We have a different ticket to make the popup appear with a shortcut, once this is implemented one can see the actual popup.

Issue: #1938

Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
@MarkusObendrauf MarkusObendrauf self-assigned this Sep 8, 2023
Copy link
Contributor

@MarkusObendrauf MarkusObendrauf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

image

@meretp meretp merged commit 8284ddc into opossum-tool:main Sep 8, 2023
@meretp meretp deleted the create-popup-skeleton branch September 8, 2023 14:01
@meretp meretp linked an issue Sep 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1935] Create popup skeleton
2 participants