Open locator popup with shortcut #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ElectronBackend/main/menu.ts
Outdated
Comment on lines
247
to
255
| icon: nativeTheme?.shouldUseDarkColors | ||
| ? path.join( | ||
| getBasePathOfAssets(), | ||
| 'icons/location-searching-white.png', | ||
| ) | ||
| : path.join( | ||
| getBasePathOfAssets(), | ||
| 'icons/location-searching-black.png', | ||
| ), |
There was a problem hiding this comment.
It seems this code is repeated a lot. Might be nice to rafactor it such that it takes two file names and returns the icon that fits the theme.
There was a problem hiding this comment.
Good idea, I extracted a method for this.
|
The commit message should contain the issue number and a description what was done. Would be nice if you could add that. |
The popup to locate signals can now be opened via shortcut Ctrl+L/Cmd+L or via the top bar if an Opossum file is opened. This commit also includes a small refactoring which extracts a method to choose the correct icon based on the theme (dark or light) used. Issue: opossum-tool#1947 Signed-off-by: Meret Behrens <meret.behrens@tngtech.com>
meretp
force-pushed
the
open-popup-with-shortcut
branch
from
d749fd1 to
ddee116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
With this PR the previously introduced popup to locate signals can be openend via the shortcut Ctrl+L or Cmd+L or via the Top bar. I also added a new icon for this functionality.
Context and reason for change
We want to imlement a new feature to be able to locate signals based on criticality and certain licenses.
How can the changes be tested
Run the unittests.
Check out the PR and start OpossumUI. If you don't open a file the shortcut Ctrl+L or Cmd+L and will do nothing. But you will see the option "Locate Signals" in the top bar menu as in the screenshot below.
Next, open a file and use Ctrl+L or Cmd+L and observe that the popup shows up as in the screenshot below.
Solves #1947.