Introduce icon indicating that there are filters selected #1969
+160
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusObendrauf
force-pushed
the
filter-icon
branch
from
7523355 to
863a443
Compare
|
fixed merge conflicts |
MarkusObendrauf
force-pushed
the
filter-icon
branch
3 times, most recently
from
11171a1 to
5e5160b
Compare
benedikt-richter
suggested changes
Sep 14, 2023
MarkusObendrauf
force-pushed
the
filter-icon
branch
2 times, most recently
from
fc973cb to
c538d20
Compare
Disable e2e tests as we had many timeouts and issues with the caching of node modules. Signed-off-by: Benedikt Richter <benedikt.richter@tngtech.com>
Display a location icon on the top bar whenever locator popup filters are active. Clicking on it opens the locator popup. Signed-off-by: Markus Obendrauf <markusobendrauf@fb.com>
MarkusObendrauf
force-pushed
the
filter-icon
branch
from
c538d20 to
e716699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Display a locator icon on the virtualized tree whenever locator popup filters are active. Clicking on it opens the locator popup.
Context and reason for change
This allows a user to see that they have filters active, and gives another way to open the popup.
How can the changes be tested
Open the popup with Ctrl+L, then select some filters.