Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for preferred attributions #2014

Merged

Conversation

davidmundelius
Copy link
Contributor

Summary of changes

We add a new filter to attribution view and audit view to filter for preferred attributions.

Context and reason for change

We want to make it possible for users to mark attributiions as preferred. Therefore we also want a filter for these attributions.

How can the changes be tested

Run the new unit test in src/Frontend/util/tests/use-filters.test.tsx.
Open the updated file opossum_input.json from the example-files folder in OpossumUI. Go to attribution view and select the new filter. There should be exactly one attribution in the filtered list.

Fix: #1990

In attribution view and audit view we add a new filter for only the preferred attributions.

Fix: opossum-tool#1990

Signed-off-by: davidmundelius <david.mundelius@tngtech.com>
@antonbauhofer antonbauhofer self-requested a review September 20, 2023 11:49
@antonbauhofer antonbauhofer self-assigned this Sep 20, 2023
Copy link
Member

@antonbauhofer antonbauhofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implemented changes look good to me. The testplan works as expected.

@antonbauhofer antonbauhofer merged commit 679fcf7 into opossum-tool:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1987] Add filter for preferred attributions
2 participants