Preferred flag is dropped for pre-selected attributions #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… attributions. When creating pre-selected attributions from external attributions in the electron backend, the preffered flag should be dropped, i.e., there are no pre-selected attributions which are preferred. Issue: opossum-tool#2007 Fix: opossum-tool#2007 Signed-off-by: Florian Schepers <florianschepers@gmx.de>
benedikt-richter
approved these changes
Sep 20, 2023
| @@ -190,7 +190,7 @@ describe('parseOpossumFile', () => { | |||
| const opossumFilePath = path.join( | |||
| upath.toUnix(temporaryPath), | |||
| 'test.opossum', | |||
| ); //test | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When creating a manual attribution from a pre-selected external attribution the preferred flag and the list of preferredOverOriginIds are deleted.
Context and reason for change
We do not want that new preferred attributions are created automatically via pre-selection.
How can the changes be tested
Run tests in 'importFromFile.test.ts'.
Issue: #2007
Fix: #2007