Improve locate popup handling #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasily-pozdnyakov
approved these changes
Sep 21, 2023
| @@ -319,4 +319,34 @@ describe('locateResourcesByCriticalityAndLicense', () => { | |||
| expectedLocatedResources, | |||
| ); | |||
| }); | |||
|
|
|||
| it('shows message when no filters are set, but no signals located', () => { | |||
There was a problem hiding this comment.
filters are set?
|
|
||
| const noSignalsAreFound = | ||
| locatedResources.size === 0 && resourcesWithLocatedChildren.size === 0; | ||
| const AllFiltersAreEmpty = |
There was a problem hiding this comment.
probably should start with small a.
- Close popup when pressing apply and signals are located or no filter is set - Inform user when apply is pressed and no signals are located - Only change state when clicking on "apply" (not when clicking "clear") - Test that the message is shown Signed-off-by: Anton Bauhofer <anton.bauhofer@tngtech.com>
antonbauhofer
force-pushed
the
improve-locator-popup-handling
branch
from
13ce759 to
9e6aee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fixes #2019
Context and reason for change
We are introducing a feature to "locate" resources that have or contain attributions with criteria that can be set in a new popup.
How can the changes be tested
Open OpossumUI, select "Locate Signals" in the edit context. In the popup, set the filters to search for a signal that does not exist, press "apply" and observe that the message is shown. Then, search for an existing signal, press "apply" and verify that the popup closes.
Note: Please review the guidelines for contributing to this repository.