Fix incorrect count of merged hhc signals #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbauhofer
approved these changes
Sep 21, 2023
Now we take max value instead of sum Signed-off-by: Vasily Pozdnyakov <vasily.pozdnyakov@tngtech.com>
vasily-pozdnyakov
force-pushed
the
fix_hhc_signals_count
branch
from
4459be3 to
7e6cd25
Compare
|
simplified the logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Instead of summarizing of all the similar hhc signals, now we just take the max value. I decided to go easy way (not adding a lot of extra logic of deduplication of resources) as the metrics is not the most important and accurate anyway.
Context and reason for change
For merged hhc signals (where only comments are different ) there is incorrect count of signals (just a sum of all of them) which is not realistic.
How can the changes be tested
Run tests.
Open any project with merged signals and see that the number is more real now.
Note: Please review the guidelines for contributing to this repository.