Update temporary package info instead of saving when prefering or unprefering an attribution on Audit View #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leslielazzarino
force-pushed
the
do-not-mark-as-preferred-globally
branch
from
6f71a43 to
a33165f
Compare
MarkusObendrauf
requested changes
Sep 25, 2023
src/Frontend/Components/AttributionColumn/attribution-column-helpers.ts
Outdated
Show resolved
Hide resolved
src/Frontend/state/actions/resource-actions/__tests__/all-views-simple-actions.test.ts
Outdated
Show resolved
Hide resolved
src/Frontend/Components/ResourceDetailsAttributionColumn/ResourceDetailsAttributionColumn.tsx
Show resolved
Hide resolved
leslielazzarino
force-pushed
the
do-not-mark-as-preferred-globally
branch
from
a33165f to
3a1d670
Compare
MarkusObendrauf
requested changes
Sep 25, 2023
leslielazzarino
force-pushed
the
do-not-mark-as-preferred-globally
branch
2 times, most recently
from
11f6ff9 to
5fedf99
Compare
…preferring an attribution on Audit View Also disable global save, including just doing a local save with ctrl+S Signed-off-by: leslielazzarino <leslie.lazzarino@gmail.com>
leslielazzarino
force-pushed
the
do-not-mark-as-preferred-globally
branch
from
5fedf99 to
d97c6bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests are still missing
Summary of changes
Update temporary package info instead of saving when prefering or unprefering an attribution on Audit View. Also the global saving button is disabled if an attribution has been changed to preferred.
Context and reason for change
That prevents collisions with unsaved changes in the attribution.
How can the changes be tested
Set-unset the preferred attribute.