Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show preferred attribution icon at package cards #2042

Conversation

vasily-pozdnyakov
Copy link
Contributor

@vasily-pozdnyakov vasily-pozdnyakov commented Sep 25, 2023

Summary of changes

Now package cards with preferred attributions are with preferred icon (star)

Context and reason for change

Fix #2037

How can the changes be tested

Mark some attribution as preferred and check Audit and Attribution views.
image

@benedikt-richter benedikt-richter self-assigned this Sep 25, 2023
Copy link
Member

@benedikt-richter benedikt-richter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small point

Signed-off-by: Vasily Pozdnyakov <vasily.pozdnyakov@tngtech.com>
@benedikt-richter benedikt-richter merged commit 82eafd4 into opossum-tool:main Sep 26, 2023
@vasily-pozdnyakov vasily-pozdnyakov deleted the 2037_mark_preferred_attribution branch November 22, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1987] Preferred attributions should be marked by a star
2 participants