fix: introduce proper error boundary #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstykow
force-pushed
the
fix-error-boundary
branch
from
5586bed to
4577218
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
from
096c50d to
6c6cad1
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
4577218 to
c95f332
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
from
6c6cad1 to
c0c3bff
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
c95f332 to
5981eaf
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
from
c0c3bff to
4abb826
Compare
|
Nice. Lgtm (Before the most recent rebase at least...) |
mstykow
force-pushed
the
feat-opossumui-2.0
branch
14 times, most recently
from
e49bc07 to
2ec903d
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
5981eaf to
650f332
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
2 times, most recently
from
c9b54aa to
a0de24d
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
650f332 to
c63f6f3
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
3 times, most recently
from
72eb751 to
7c556e9
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
c63f6f3 to
eab880b
Compare
alexzurbonsen
approved these changes
Mar 5, 2024
mstykow
force-pushed
the
feat-opossumui-2.0
branch
4 times, most recently
from
99140be to
f2c7fc3
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
eab880b to
397ecff
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
from
f2c7fc3 to
0c6d8c5
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
397ecff to
18abc69
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
2 times, most recently
from
3c02b80 to
d26f86d
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
18abc69 to
7b7605b
Compare
mstykow
force-pushed
the
feat-opossumui-2.0
branch
from
d26f86d to
d0c56c4
Compare
mstykow
force-pushed
the
fix-error-boundary
branch
from
7b7605b to
742d223
Compare
- add methods to quit or relaunch the app - create error boundary that displays error and offers options to relaunch or quit closes #2564 Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
fix-error-boundary
branch
from
742d223 to
873d5cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
closes #2564
How can the changes be tested
You must produce an unexpected error. For example, you could start the app locally and change the code somewhere to break it, e.g., put this into
ReportViewto trigger an unexpected error when the user switches to report view:console.log(null.map())