feat: collapse license text by default #2636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstykow
force-pushed
the
collapse-license-text-by-default
branch
from
2c5c55f to
5fd6428
Compare
- prevent license text from taking up vertical space by introducing toggle button to show/hide it - rename "package" to "component" for OSS naming consistency - make sure icon button keyboard-focus style is separate from click-focus style Signed-off-by: Maxim Stykow <maxim.stykow@tngtech.com>
mstykow
force-pushed
the
collapse-license-text-by-default
branch
from
5fd6428 to
b37a4b3
Compare
alexzurbonsen
approved these changes
May 17, 2024
Comment on lines
+98
to
+104
| <Badge | ||
| anchorOrigin={{ vertical: 'bottom', horizontal: 'right' }} | ||
| color={'info'} | ||
| variant={'dot'} | ||
| invisible={!packageInfo.licenseText} | ||
| > | ||
| <NotesIcon /> |
There was a problem hiding this comment.
Subjective: I think it could also be nice to just give the color to the Icon, instead of adding a badge. But go with what you think is best.
There was a problem hiding this comment.
i tried color first but that's not how the MUI toggle button is designed: it will only display the color once it's active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
User feedback on smaller screens revealed that we are unnecessarily taking up vertical space which forces frequent scrolling to see comments.
How can the changes be tested
Try the new toggle button with and without changed license texts.