Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change field "license name" to "license expression" #2701

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

Hellgartner
Copy link
Contributor

Summary of changes

Change the label for the license name field to license expression as it better describes the actual possibilities

Context and reason for change

The field "license name" can be used to enter license expressions. Since not every license expression is a license name but the converse is true, it would be more correct to name the field "license expression".

Fixes #2689

How can the changes be tested

  • Open the new version of Opossum UI
  • Load any file
  • Check any attribution
    image

See also

Note: Please review the guidelines for contributing to this repository.

@Hellgartner Hellgartner requested a review from mstykow January 3, 2025 08:17
- Change the label for the license name field to license expression
as it better describes the actual possibilities
- Adapt and extend tests
- Add myself to the CONTRIBUTORS.md

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner Hellgartner force-pushed the fix-license-name-field-label branch from b2df4f6 to 678ce0d Compare January 3, 2025 12:50
@Hellgartner Hellgartner merged commit 9bb6811 into main Jan 3, 2025
5 checks passed
@Hellgartner Hellgartner deleted the fix-license-name-field-label branch January 3, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change field "license name" to "license expression"
2 participants