Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create .snap and app image for linux #2739

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

Hellgartner
Copy link
Contributor

Summary of changes

Build process now builds a '.snap' image additionally to the appImage

Context and reason for change

How can the changes be tested

run yarn ship:auto on a linux machine

Note: Please review the guidelines for contributing to this repository.

@Hellgartner Hellgartner force-pushed the feat_build_snap_and_app_image branch from fc059c2 to b28e11d Compare January 31, 2025 15:02
@Hellgartner Hellgartner marked this pull request as ready for review January 31, 2025 15:09
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
* switch to ubuntu latest again
* add the --no-sandbox argument in that case

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner Hellgartner force-pushed the feat_build_snap_and_app_image branch from 5e4692c to b5ff043 Compare February 3, 2025 10:48
Copy link
Contributor

@abraemer abraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and even works on my machine 👍

@abraemer abraemer merged commit 454fd15 into main Feb 4, 2025
5 checks passed
@abraemer abraemer deleted the feat_build_snap_and_app_image branch February 4, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For linux build snap and app image
2 participants