Feat: Import ScanCode Json Files #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippMa
force-pushed
the
feat/import-scancode
branch
from
f2c76ac to
e9aa212
Compare
Hellgartner
requested changes
Feb 3, 2025
src/ElectronBackend/main/openFileFromCliOrEnvVariableIfProvided.ts
Outdated
Show resolved
Hide resolved
src/ElectronBackend/opossum-file/__tests__/convertToOpossum.test.ts
Outdated
Show resolved
Hide resolved
PhilippMa
force-pushed
the
feat/import-scancode
branch
2 times, most recently
from
9029466 to
5eff797
Compare
* allows importing scancode .json files through the import dialog by using the opossum-file converter
* put scancode input file directly in test directory to avoid path issues
…ate handling * by creating a new ImportDialog instance every time it is opened, no manual state resets are needed * ImportDialog can also safely assume that fileFormat always has a proper value * It also conceptually makes sense to separate the IPC listening logic from the dialog that it opens
* currently only support for .opossum files is needed * support for legacy files is no longer needed * support for importing other file formats may become useful later but can be postponed to another issue
* default bottom placement overlaps with component for save location selection
PhilippMa
force-pushed
the
feat/import-scancode
branch
from
723c8f8 to
7b67cf5
Compare
* running test:unit also sets NODE_ENV=test, but in this case we don't need to correct the path to opossum-file
Hellgartner
approved these changes
Feb 11, 2025
| // need to make sure that the confirmSavePopup is closed before any assertions | ||
| // are run on linkedResourcesTree, because the confirmSavePopup also contains | ||
| // a LinkedResourcesTree which makes locators resolve to 2 elements | ||
| await confirmSavePopup.assert.isHidden(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
By connecting the previously implemented import dialog with the existing backend interface for opossum-file, it is now possible to import ScanCode Json files into OpossumUI.
Context and reason for change
We want OpossumUI to be usable with different foreign file formats.
closes #2718