Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sort common licenses to top #2757

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Hellgartner
Copy link
Contributor

@Hellgartner Hellgartner commented Feb 6, 2025

Summary of changes

In the license panel, first show the common licenses

Context and reason for change

The common licenses should be the default choice for using a license
--> sort to the top
image

closes: #2755

How can the changes be tested

open any attribution in opossum-ui

Signed-off-by: Dominikus Hellgartner <dominikus.hellgartner@tngtech.com>
@Hellgartner Hellgartner marked this pull request as ready for review February 6, 2025 09:00
@PhilippMa PhilippMa self-assigned this Feb 6, 2025
Copy link
Contributor

@PhilippMa PhilippMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hellgartner Hellgartner merged commit 1c0e253 into main Feb 6, 2025
5 checks passed
@Hellgartner Hellgartner deleted the feat/sort_common_licenses_to_top branch February 6, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort common licenses to the top
2 participants