Check for unsaved changes before import/open/export #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* just importing without saving leads to loss of most recent edits * this change required reintegrating ImportDialog with the GlobalPopup system * caused by NotSavedPopups heavy usage of redux state
* exporting when there are unsaved changes can lead to unexpected behavior
mstykow
reviewed
Feb 13, 2025
mstykow
requested changes
Feb 13, 2025
Hellgartner
requested changes
Feb 14, 2025
src/Frontend/state/actions/popup-actions/__tests__/popup-actions.test.ts
Show resolved
Hide resolved
mstykow
approved these changes
Feb 14, 2025
* we want to be able to trigger these events from the frontend as well
…ttributions.test.ts
PhilippMa
force-pushed
the
feat/increase-notsaved-checks
branch
from
7e3d860 to
8d95f1d
Compare
Hellgartner
reviewed
Feb 17, 2025
src/Frontend/Components/ProcessPopup/__tests__/ProcessPopup.test.tsx
Outdated
Show resolved
Hide resolved
Hellgartner
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
If unsaved changes are present when the user clicks on import/open/export, the NotSavedPopup is shown and they can only proceed if they explicitly discard their current changes.
Context and reason for change
Importing or opening a file while there are unsaved changes implicitly discards these changes. Exported documents do not reflect unsaved changes.
How can the changes be tested
Change any field of an attribution, then click on import/open/export.
closes #2775