Merging input files (App)

[PhilippMa]

Summary of changes

Fully integrate merging of input files into OpossumUI.

• add menu entry for merge
• show dialog for selecting input file when clicking the menu item
  • show NotSavedPopup first if there are unsaved changes
• when user clicks "Merge" in the dialog, the merge functionality implemented in Merging of input files (Backend logic) #2797 is invoked

Context and reason for change

We want users to be able to merge more information from external files into their currently open .opossum file directly from OpossumUI.

How can the changes be tested

Open a file in OpossumUI, then merge a second file into it using the new workflow, check that data from both files made it into the merged file.

closes #2730

[Hellgartner]

This should have probably been two stacked PRs:

• The Menu refactor at the beginning
• Then the real merge functionality

[mstykow]

Could you please move the "..." to Import/Merge rather than after the options?

[mstykow]

I selected "merge scancode json" but then used a non-scancode json. Expectedly, I got an error. But shouldn't we give a better message what exactly is wrong than just saying that there is some failure?

[mstykow]

This is not vertically aligned, i.e., the icon is too high or the text is too low, depending on how you look at it.

[mstykow]

"ScanCode File" is not a proper noun, only "ScanCode" is. I would lower-case "file".

[mstykow]

"Opossum", however, is a proper noun. Please capitalize. Comment also applies to the "import" dialog, not just the "merge".

[mstykow]

Let's not capitalize an entire word/sentence. But what you can do here is to suggest to the user to make a backup of their Opossum file before merging.

[PhilippMa]

Could you please move the "..." to Import/Merge rather than after the options?

Are you sure that is the standard? While implementing this I had a look at the menu in JetBrains IDEs as reference, and at least there it seems that menu items containing submenus never have a "..." suffix, and the dots are rather only used on "leaf" menu items which open a popup/dialog instead of immediately executing an action.

[PhilippMa]

I selected "merge scancode json" but then used a non-scancode json. Expectedly, I got an error. But shouldn't we give a better message what exactly is wrong than just saying that there is some failure?

I feel like this would need some further planning as to which kinds of errors we could reasonably distinguish, so I would suggest implementing this as part of a new issue. Or do you see any improvements that would make sense to already include in this PR?

[mstykow]

Could you please move the "..." to Import/Merge rather than after the options?

Are you sure that is the standard? While implementing this I had a look at the menu in JetBrains IDEs as reference, and at least there it seems that menu items containing submenus never have a "..." suffix, and the dots are rather only used on "leaf" menu items which open a popup/dialog instead of immediately executing an action.

You're right. Ignore my suggestion and keep as is.

[mstykow]

General comment: please think about how you can keep your PRs smaller.