Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classification to internal data model #2810

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

PhilippMa
Copy link
Contributor

Summary of changes

Added classification to internal data model:

  • Add field for classification config in resource state
  • Add classification field on attributions

Context and reason for change

Upcoming tickets will need access to classification data included in .opossum files.

How can the changes be tested

  • Check that files can be parsed and opened without error
  • (Optional) log parts of internal state to console after load has finished, check that classification data in internal state is correct

@abraemer abraemer self-assigned this Feb 24, 2025
@abraemer abraemer self-requested a review February 24, 2025 09:16
Copy link
Contributor

@abraemer abraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

abraemer
abraemer approved these changes Feb 24, 2025
@PhilippMa PhilippMa merged commit 09512d5 into main Feb 24, 2025
5 checks passed
@PhilippMa PhilippMa deleted the feat/internal-model-for-classification branch February 24, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants