Unify handling of loading state #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the loading state is set/unset from the backend only * frontend components directly listen on the FileLoading ipc channel again, no more loading state in redux * add StopLoading ipc channel as a temporary solution for handling loading state on export (see issue 2812)
* error messages are not displayed in dialog otherwise
mstykow
requested changes
Feb 24, 2025
PhilippMa
force-pushed
the
refactor/unify-loading-state
branch
from
380ccec to
7c23e99
Compare
mstykow
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
How can the changes be tested
Check that the ProcessPopup is shown for open/export and that the import dialog properly displays logs during loading.