Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Context and reason for change
The strength of Faker is the random generation of valid inputs. With a fixed seed this advantage is lost. For incomprehensible reasons, there was no randomization taking place. This PR fixes that be altering the setup slightly.
How the changes can be tested
Dump a few generated documents, e.g. by putting this snippet:
at the end of
tests/input_formats/scancode/services/test_convert_to_opossum.py
and running it a couple of times.Before this change, this yields identical files. After this change, the file is different everytime.