Update opossum schema for classification and config #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abraemer
force-pushed
the
update-opossum-schema-for-classification
branch
from
5dac3ce to
5e88468
Compare
* includes config toplevel key and classification key for externalAttribution * The change of the OpossumFileModel classes triggers a few changes throughout the code base * There are new tests for merge_opossum and generate for a new input file with config+classification
abraemer
force-pushed
the
update-opossum-schema-for-classification
branch
from
5e88468 to
ff176b3
Compare
Hellgartner
requested changes
Feb 19, 2025
src/opossum_lib/input_formats/opossum/services/convert_to_opossum.py
Outdated
Show resolved
Hide resolved
* this makes a few places a bit more ergonomic (test, merge_opossums) * when converting back, we translate an empty classifications to None to not to be backwards compatible
* This means this PR is now fully backwards compatible in the sense that we never generate something different from the old schema if we don't have to
Hellgartner
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
_assert_expected_file_equals_generated_filea bit more lenient by treatingNoneand empty containers as equivalentContext and reason for change
See opossum-tool/OpossumUI#2800
Compatibility
This change is backwards compatible. Everything that worked before still works. However old version of
opossum-filedo not work on new opossum files that includeclassificationorconfig.How can the changes be tested
Tests are included. If you want to see it for yourself, you can run: