Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): omit explicit lifetime #156

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Dec 4, 2024

clippy throws an error in CI:

error: the following explicit lifetimes could be elided: 'a
  --> src/upload.rs:72:6
   |
72 | impl<'a, R: Read> Read for UploadTracker<'a, R> {
   |      ^^                                  ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
   |
72 - impl<'a, R: Read> Read for UploadTracker<'a, R> {
72 + impl<R: Read> Read for UploadTracker<'_, R> {
   |

error: could not compile `rustypaste-cli` (lib) due to 1 previous error

@tessus
Copy link
Collaborator Author

tessus commented Dec 5, 2024

@orhun can you quickly have a look at this?

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 250e949 into orhun:master Dec 7, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants