Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/update-osbuild: extend PR commit message #1172

Merged

Conversation

schuellerf
Copy link
Contributor

Extends the "update dependency PR" commit message to also contain a link to the exact changes for easier review.

e.g. the Message of #1169 would be

Updating osbuild dependency commit IDs to current `main`

Changes: https://github.com/osbuild/osbuild/compare/55d53f58fdbe6f328581f12c4548efb80aa5ca19...e4333f87ba14f85ba3d9aa5b070190d82d06a297

similar change could be done with ./test/scripts/update-schutzfile-bib in a separate PR

Extends the "update dependency PR" commit message to
also contain a link to the exact changes for easier review.
@schuellerf schuellerf requested review from achilleas-k, thozza and a team as code owners January 28, 2025 12:45
@schuellerf schuellerf requested a review from mvo5 January 28, 2025 12:45
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schuellerf schuellerf enabled auto-merge January 28, 2025 12:57
@schuellerf schuellerf added this pull request to the merge queue Jan 28, 2025
@schuellerf
Copy link
Contributor Author

@thozza there is no problem in re-running the action manually, see if it works and close the duplicate PR, right?

should I then continue to implement this also for the bib script?

@thozza
Copy link
Member

thozza commented Jan 28, 2025

@thozza there is no problem in re-running the action manually, see if it works and close the duplicate PR, right?

Yes, should be possible.

should I then continue to implement this also for the bib script?

Sure, feel free to do the change.

Eventually, we may want to auto-merge these PRs if CI passes for them.

Merged via the queue into osbuild:main with commit 40d8940 Jan 28, 2025
18 checks passed
@schuellerf schuellerf deleted the extend-update-dependency-PR-commit-message branch January 28, 2025 14:01
@schuellerf
Copy link
Contributor Author

Eventually, we may want to auto-merge these PRs if CI passes for them.

I think a quick sanity check and LGTM is ok 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants