Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policies: allow custom directories and files under /usr/local #1190

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

ondrejbudai
Copy link
Member

According to FHS, /usr/local is meant for installing software locally.
Thus, this directory feels like the ideal place for extra software
installed by Image Builder's users via the custom files and directories.

This commit relaxes the custom files and directory policies so users
can add arbitrary files and directories under /usr/local.

@ondrejbudai ondrejbudai requested a review from a team as a code owner February 3, 2025 13:20
@schutzbot
Copy link
Contributor

schutzbot commented Feb 3, 2025

A previous version of this PR changed the images API or behaviour causing integration issues with osbuild-composer.
This is now fixed.

@achilleas-k achilleas-k changed the title policies: allow custom directories and filed under /usr/local policies: allow custom directories and files under /usr/local Feb 3, 2025
@achilleas-k
Copy link
Member

We should also add some tests for the file and directory policies to the package tests here.

@achilleas-k
Copy link
Member

Not sure what kind of weird glitch made everything fail earlier but it seems to be okay now.

Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achilleas-k
Copy link
Member

Spoke too soon

@achilleas-k
Copy link
Member

ah wait. The merge base of this PR is very old (from Dec). Updating.

According to FHS, /usr/local is meant for installing software locally.
Thus, this directory feels like the ideal place for extra software
installed by Image Builder's users via the custom files and directories.

This commit relaxes the custom files and directory policies so users
can add arbitrary files and directories under /usr/local.
@thozza thozza added this pull request to the merge queue Feb 3, 2025
Merged via the queue into osbuild:main with commit e569940 Feb 3, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants