-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[noetic] Fix install and improve Python 3 support #94
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
ab9577f
to
acc3deb
Compare
Remaining test failures are due to the package pycodestyle having a faulty rosdep rule (ros/rosdistro#27546) and is unrelated to this change |
@ros-pull-request-builder retest this please |
👍 |
Just pinging this thread. Is it possible to merge it? |
agreed, modernize tends to introduce unnecessary changes. |
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
4785e13
to
7de19ba
Compare
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
b8d28e1
to
3ff4c8f
Compare
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
@wjwwood Here is a shorter version of this PR, PTAL. @stwirth @Rezenders could you check if this version works for you ? |
I'm not sure what the source of the error from travis-ci is, but it would be best to fix that. The melodic failure looks related:
|
This PR allow the capability server to start, currently it fails with:
The third commit runs
modernize
on the codebase which fixed all the Python3 problems I was facing when trying to run the demo