Handle parentheses in no-self-compare

oxc-project · Mar 11, 2025 · 20a71c7 · 20a71c7
1 parent 4a773ff
commit 20a71c7
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 3 deletions.
diff --git a/crates/oxc_linter/src/rules/eslint/no_self_compare.rs b/crates/oxc_linter/src/rules/eslint/no_self_compare.rs
@@ -48,7 +48,11 @@ impl Rule for NoSelfCompare {
             return;
         }
 
-        if binary_expr.left.content_eq(&binary_expr.right) {
+        if binary_expr
+            .left
+            .without_parentheses()
+            .content_eq(&binary_expr.right.without_parentheses())
+        {
             ctx.diagnostic(no_self_compare_diagnostic(
                 binary_expr.left.span(),
                 binary_expr.right.span(),
@@ -81,11 +85,12 @@ fn test() {
         ("x == x", None),
         ("x != x", None),
         ("x > x", None),
-        ("x > (x)", None),
-        ("(x) > x", None),
         ("x < x", None),
         ("x >= x", None),
         ("x <= x", None),
+        ("x > (x)", None),
+        ("(x) == x", None),
+        ("(x) >= ((x))", None),
         ("foo.bar().baz.qux >= foo.bar ().baz .qux", None),
         ("class C { #field; foo() { this.#field === this.#field; } }", None),
     ];

diff --git a/crates/oxc_linter/src/snapshots/eslint_no_self_compare.snap b/crates/oxc_linter/src/snapshots/eslint_no_self_compare.snap
@@ -92,6 +92,27 @@ source: crates/oxc_linter/src/tester.rs
    ╰────
   help: If you are testing for NaN, you can use Number.isNaN function.
 
+  ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
+   ╭─[no_self_compare.tsx:1:1]
+ 1 │ x > (x)
+   · ─   ───
+   ╰────
+  help: If you are testing for NaN, you can use Number.isNaN function.
+
+  ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
+   ╭─[no_self_compare.tsx:1:1]
+ 1 │ (x) == x
+   · ───    ─
+   ╰────
+  help: If you are testing for NaN, you can use Number.isNaN function.
+
+  ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
+   ╭─[no_self_compare.tsx:1:1]
+ 1 │ (x) >= ((x))
+   · ───    ─────
+   ╰────
+  help: If you are testing for NaN, you can use Number.isNaN function.
+
   ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
    ╭─[no_self_compare.tsx:1:1]
  1 │ foo.bar().baz.qux >= foo.bar ().baz .qux