fix(linter): Add missing fail cases in eslint/no-self-compare (#9693)

Handles parentheses wrapping the LHS and RHS of the binary operation so
that the following missing test cases pass:

```js
x > (x)

(x) == x

(x) >= ((x))
```

Eslint playground for these fail cases above can be found
[here](https://eslint.org/play/#eyJ0ZXh0IjoiLyplc2xpbnQgbm8tc2VsZi1jb21wYXJlOiBcImVycm9yXCIqL1xuXG5pZiAoeCA+ICh4KSkge31cblxuaWYgKCh4KSA9PSB4KSB7fVxuXG5pZiAoKHgpID49ICgoeCkpKSB7fSIsIm9wdGlvbnMiOnsicnVsZXMiOnt9LCJsYW5ndWFnZU9wdGlvbnMiOnsicGFyc2VyT3B0aW9ucyI6eyJlY21hRmVhdHVyZXMiOnt9fX19fQ==).

crates/oxc_linter/src/rules/eslint/no_self_compare.rs

@@ -48,7 +48,11 @@ impl Rule for NoSelfCompare {
             return;
         }
 
-        if binary_expr.left.content_eq(&binary_expr.right) {
+        if binary_expr
+            .left
+            .without_parentheses()
+            .content_eq(binary_expr.right.without_parentheses())
+        {
             ctx.diagnostic(no_self_compare_diagnostic(
                 binary_expr.left.span(),
                 binary_expr.right.span(),
@@ -84,6 +88,9 @@ fn test() {
         ("x < x", None),
         ("x >= x", None),
         ("x <= x", None),
+        ("x > (x)", None),
+        ("(x) == x", None),
+        ("(x) >= ((x))", None),
         ("foo.bar().baz.qux >= foo.bar ().baz .qux", None),
         ("class C { #field; foo() { this.#field === this.#field; } }", None),
     ];

crates/oxc_linter/src/snapshots/eslint_no_self_compare.snap

@@ -92,6 +92,27 @@ source: crates/oxc_linter/src/tester.rs
    ╰────
   help: If you are testing for NaN, you can use Number.isNaN function.
 
+  ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
+   ╭─[no_self_compare.tsx:1:1]
+ 1 │ x > (x)
+   · ─   ───
+   ╰────
+  help: If you are testing for NaN, you can use Number.isNaN function.
+
+  ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
+   ╭─[no_self_compare.tsx:1:1]
+ 1 │ (x) == x
+   · ───    ─
+   ╰────
+  help: If you are testing for NaN, you can use Number.isNaN function.
+
+  ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
+   ╭─[no_self_compare.tsx:1:1]
+ 1 │ (x) >= ((x))
+   · ───    ─────
+   ╰────
+  help: If you are testing for NaN, you can use Number.isNaN function.
+
   ⚠ eslint(no-self-compare): Both sides of this comparison are exactly the same
    ╭─[no_self_compare.tsx:1:1]
  1 │ foo.bar().baz.qux >= foo.bar ().baz .qux