Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semantic)!: combine SymbolTable and ScopeTree into Scoping #9615

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Mar 8, 2025

closes #9607

Copy link
Member Author

Boshen commented Mar 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-semantic Area - Semantic C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 8, 2025
@Boshen Boshen force-pushed the 03-08-refactor_semantic_combine_symboltable_and_scopetree_into_scoping_ branch from cf9f16f to 28c6731 Compare March 9, 2025 05:43
@Boshen Boshen force-pushed the 03-08-refactor_semantic_add_scoping_to_semantic_ branch from 3ac893e to d42b7d6 Compare March 9, 2025 05:43
@Boshen Boshen marked this pull request as ready for review March 9, 2025 05:43
@github-actions github-actions bot added A-linter Area - Linter A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation labels Mar 9, 2025
Copy link

codspeed-hq bot commented Mar 9, 2025

CodSpeed Performance Report

Merging #9615 will not alter performance

Comparing 03-08-refactor_semantic_combine_symboltable_and_scopetree_into_scoping_ (ef6e0cc) with 03-08-refactor_semantic_add_scoping_to_semantic_ (a43c341)

Summary

✅ 39 untouched benchmarks

@Boshen Boshen force-pushed the 03-08-refactor_semantic_combine_symboltable_and_scopetree_into_scoping_ branch from 28c6731 to 29edb34 Compare March 9, 2025 06:08
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 9, 2025
Copy link
Member Author

Boshen commented Mar 9, 2025

Merge activity

  • Mar 9, 6:27 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 9, 6:27 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 9, 6:53 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 03-08-refactor_semantic_add_scoping_to_semantic_ branch from d42b7d6 to a43c341 Compare March 9, 2025 10:29
@graphite-app graphite-app bot force-pushed the 03-08-refactor_semantic_combine_symboltable_and_scopetree_into_scoping_ branch from 29edb34 to ef6e0cc Compare March 9, 2025 10:29
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 9, 2025
Base automatically changed from 03-08-refactor_semantic_add_scoping_to_semantic_ to main March 9, 2025 10:50
@graphite-app graphite-app bot merged commit ef6e0cc into main Mar 9, 2025
35 checks passed
@graphite-app graphite-app bot deleted the 03-08-refactor_semantic_combine_symboltable_and_scopetree_into_scoping_ branch March 9, 2025 10:53
Boshen added a commit that referenced this pull request Mar 11, 2025
## [0.57.0] - 2025-03-11

- 510446a parser: [**BREAKING**] Align JSXNamespacedName with ESTree
(#9648) (Arnaud Barré)

- b0d979d semantic: [**BREAKING**] Make `Scoping::references` private
(#9629) (Boshen)

- 3c6f140 semantic: [**BREAKING**] Make `Scoping` methods consistent
(#9628) (Boshen)

- ef6e0cc semantic: [**BREAKING**] Combine `SymbolTable` and `ScopeTree`
into `Scoping` (#9615) (Boshen)

- 7331656 semantic: [**BREAKING**] Rename `SymbolTable` and `ScopeTree`
methods (#9613) (Boshen)

- 23738bf semantic: [**BREAKING**] Introduce `Scoping` (#9611) (Boshen)

### Features

- b6deff8 ecmascript: Support integer index access for array and string
in `may_have_side_effects` (#9603) (sapphi-red)
- 047fb01 minifier: Place `void 0` on right hand side if possible
(#9606) (sapphi-red)
- 36f8703 minifier: Compress `[] + string` to `string` (#9602)
(sapphi-red)
- 554c4ce minifier: Compress constant integer index access (#9604)
(sapphi-red)
- e3c2015 minifier: Allow compressing computed __proto__ more precisely
(#9595) (sapphi-red)
- 6a57198 minifier: Allow compressing computed constructor/prototype
keys precisely (#9594) (sapphi-red)
- 638007b parser: Apply `preserveParens` to `TSParenthesizedType`
(#9653) (Boshen)

### Bug Fixes

- eae1a41 ast: Align `TSImportType` field names with ts-eslint (#9664)
(Boshen)
- 96eef8b ecmascript: `(foo() + "").length` may have a side effect
(#9605) (sapphi-red)
- 24d9261 minifier: Remove names from functions / classes in normal pass
to make the minifier idempotent (#9608) (sapphi-red)
- 6ac3635 napi/parser: Disable raw transfer on unsupported platforms
(#9651) (overlookmotel)
- cfdcfdb parser: Fix end span for optional binding pattern without type
annotation (#9652) (Boshen)
- 26da65d parser: Parse asi after class accessor property (#9623)
(Boshen)
- 87462fd parser: Fix end span for `using` declaration (#9622) (Boshen)
- 29edb51 transformer: Fix module runner transform of export default
expression (#9661) (hi-ogawa)

### Documentation

- 31a2618 allocator: Add safety constraint for
`String::from_raw_parts_in` (#9640) (overlookmotel)

### Refactor

- 44101bd allocator: Refactor and improve safty comments of
`String::from_strs_array_in` (#9639) (overlookmotel)
- c6edafe napi: Remove `npm/oxc-*/` npm packages (#9631) (Boshen)
- a43c341 semantic: Add `Scoping` to `Semantic` (#9614) (Boshen)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-codegen Area - Code Generation A-linter Area - Linter A-minifier Area - Minifier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Scoping structure combining ScopeTree and SymbolTable
1 participant