Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(transformer/using): remove unused call to enter_statement #9692

Merged
merged 1 commit into from
Mar 12, 2025
Merged

refactor(transformer/using): remove unused call to enter_statement #9692

merged 1 commit into from
Mar 12, 2025
+0 −1

Conversation

camc314
Copy link
Contributor

@camc314 camc314 commented Mar 11, 2025

No description provided.

@camc314 camc314 mentioned this pull request Mar 11, 2025
Merged
@camc314 camc314 marked this pull request as ready for review March 11, 2025 17:03
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Mar 11, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 11, 2025
@camc314 camc314 changed the title refactor(transformer): remove unused call to enter_statement refactor(transformer/using): remove unused call to enter_statement Mar 11, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 11, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9692 will not alter performance

Comparing c/03-11-refactor_transformer_remove_unused_call_to_enter_statement_ (f437a95) with main (b2fbd99)

Summary

✅ 33 untouched benchmarks

@camc314
Copy link
Contributor Author

camc314 commented Mar 11, 2025

ha not much >
Screenshot 2025-03-11 at 17 13 23

@overlookmotel overlookmotel changed the base branch from c/03-11-refactor_transformer_remove_unused_call_to_enter_statements_ to graphite-base/9692 March 12, 2025 04:19
@overlookmotel
Copy link
Contributor

Oops! We should have noticed this before.

@overlookmotel overlookmotel force-pushed the c/03-11-refactor_transformer_remove_unused_call_to_enter_statement_ branch from e6916d2 to 055c493 Compare March 12, 2025 04:24
@overlookmotel overlookmotel changed the base branch from graphite-base/9692 to main March 12, 2025 04:25
@overlookmotel overlookmotel force-pushed the c/03-11-refactor_transformer_remove_unused_call_to_enter_statement_ branch from 055c493 to e632808 Compare March 12, 2025 04:25
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
@overlookmotel Graphite App
Copy link
Contributor

overlookmotel commented Mar 12, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Mar 12, 12:41 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 12, 12:41 AM EDT: A user added this pull request to the Graphite merge queue.
  • Mar 12, 12:46 AM EDT: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the c/03-11-refactor_transformer_remove_unused_call_to_enter_statement_ branch from e632808 to f437a95 Compare March 12, 2025 04:41
@graphite-app graphite-app bot merged commit f437a95 into main Mar 12, 2025
25 checks passed
@graphite-app graphite-app bot deleted the c/03-11-refactor_transformer_remove_unused_call_to_enter_statement_ branch March 12, 2025 04:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel overlookmotel approved these changes

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees
No one assigned
Labels
A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camc314 @overlookmotel