Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(transformer/module_runner_transform): add tests for deps and dynamicDeps #9707

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 12, 2025

These tests are copied from the Vite, I missed adding them because I am thinking about removing supporting returning deps and dynamicDpes, but take into account the plugin is integrating into the Vite and Vitest, in case regression, we should add them anyway.

@Dunqing Dunqing requested a review from overlookmotel as a code owner March 12, 2025 09:06
Copy link
Member Author

Dunqing commented Mar 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Mar 12, 2025
@Dunqing Dunqing requested review from hi-ogawa and sapphi-red March 12, 2025 09:08
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

codspeed-hq bot commented Mar 12, 2025

CodSpeed Performance Report

Merging #9707 will not alter performance

Comparing 03-12-test_transformer_module_runner_transform_add_tests_for_deps_and_dynamicdeps (325a1a4) with main (0903e7e)

Summary

✅ 33 untouched benchmarks

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
Copy link

graphite-app bot commented Mar 12, 2025

Merge activity

…dynamicDeps` (#9707)

These tests are copied from the Vite, I missed adding them because I am thinking about removing supporting returning `deps` and `dynamicDpes`, but take into account the plugin is integrating into the `Vite` and `Vitest`, in case regression, we should add them anyway.
@graphite-app graphite-app bot force-pushed the 03-12-test_transformer_module_runner_transform_add_tests_for_deps_and_dynamicdeps branch from c8c9675 to 325a1a4 Compare March 12, 2025 09:27
@graphite-app graphite-app bot merged commit 325a1a4 into main Mar 12, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 12, 2025
@graphite-app graphite-app bot deleted the 03-12-test_transformer_module_runner_transform_add_tests_for_deps_and_dynamicdeps branch March 12, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler C-test Category - Testing. Code is missing test cases, or a PR is adding them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants