add toPrefix to NavLinks in Sidebar to better highlight isActive #2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks good. What do you think about renaming |
david-crespo
approved these changes
Mar 7, 2025
|
Yeah, agree that that's better. Will pick that up before merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that we were seeing with tabbed pages, where the sidebar navigation wasn't working as expected for tabbed pages.
Note how the "Inventory" link is "active" for the Sleds tab, but not the Disks tab:
This PR fixes NavLinks in the Sidebar by adding a
toPrefix, which is essentially the first part of a URL path. If a link is given atoPrefixprop, that more generic string will be used when the component is determining if the tab should be rendered as "active" or not.Here it is, fixed:
