Update icon export script #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| return ( | ||
| <Menu> | ||
| <MenuButton> | ||
| <MenuButton aria-label={`${capitalize(type)} actions`}> |
There was a problem hiding this comment.
small thing what about passing the whole thing as something like buttonLabel="Instance actions"? Even aria-label=, though that is a little ambiguous about what element it ends up labeling.
There was a problem hiding this comment.
It's a good point, I tweaked it.
|
I'm gonna go ahead and merge so that I can move on to the header work. Feel free to drop any more feedback and I'll be happy to tackle it in a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #882
This updates the icon export script to point at the new icons location in figma. I've also gone ahead and updated the icons and their references in this PR.