[zone bundle] Query for the correct user property, avoid panicking #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
approved these changes
Mar 6, 2025
jgallagher
reviewed
Mar 7, 2025
Comment on lines
+93
to
+98
| "Found a ZFS snapshot with a name reserved for zone \ | ||
| bundling, but which does not have the zone-bundle-specific \ | ||
| property. Bailing out, rather than risking deletion of \ | ||
| user data."; | ||
| "snap_name" => &name, | ||
| "property" => ZONE_BUNDLE_ZFS_PROPERTY_NAME |
There was a problem hiding this comment.
I realize this already landed, but this log should probably include the error from get_values, right? It might be that we don't have the property (as the current log message says), but it could also be something like "zfs get failed outright".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7750
Fixes #7752