Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the web process type in favor of setting default #253

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

ForestEckhardt
Copy link
Contributor

  • We now set the default on the first binary process in the target order
    instead of setting a web process type

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

- We now set the default on the first binary process in the target order
instead of setting a web process type
@ForestEckhardt ForestEckhardt requested a review from a team as a code owner November 10, 2021 22:09
ryanmoran
ryanmoran previously approved these changes Dec 1, 2021
@ryanmoran ryanmoran added the semver:minor A change requiring a minor version bump label Dec 1, 2021
@paketo-bot paketo-bot removed the semver:minor A change requiring a minor version bump label Dec 2, 2021
@ForestEckhardt ForestEckhardt added the semver:minor A change requiring a minor version bump label Dec 2, 2021
@paketo-bot paketo-bot removed the semver:minor A change requiring a minor version bump label Dec 2, 2021
@ForestEckhardt ForestEckhardt added the semver:minor A change requiring a minor version bump label Dec 2, 2021
@ForestEckhardt ForestEckhardt merged commit 4292e21 into main Dec 2, 2021
@ForestEckhardt ForestEckhardt deleted the launch-process-refactor branch December 2, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants