Use direct=true processes for go buildpack #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go buildpack currently uses direct=false processes. AFAICT, the buildpack itself, doesn't need to support direct=false process types as it does not rely on any profile.d scripts or use any environment variables as arguments for its process type. Direct=false processes also have an extremely unintuitive/error causing behavior with arg handling at runtime. For more info see https://github.com/buildpacks/rfcs/blob/main/text/0093-remove-shell-processes.md#argument-handling This also prevents divergence in the behavior of the output images between the tiny stack and the other stacks with runtime arguments being handled consistently now. This also leads to performance improvements as direct=true processes do not need to load bash/go through the shell for startup. Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
|
Hey @samj1912, see my change to make reloadable processes still work with this change. It follows the recommendation in the CNB RFC to explicitly use |
|
I'd vote minor bump on this, since the change doesn't break any of the existing integration-tested functionality of the buildpack. |
ForestEckhardt
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go buildpack currently uses direct=false processes. AFAICT,
the buildpack itself, doesn't need to support direct=false process types
as it does not rely on any profile.d scripts or use any environment
variables as arguments for its process type. Direct=false processes
also have an extremely unintuitive/error causing behavior with arg
handling at runtime. For more info see
https://github.com/buildpacks/rfcs/blob/main/text/0093-remove-shell-processes.md#argument-handling
This also prevents divergence in the behavior of the output images
between the tiny stack and the other stacks with runtime arguments being
handled consistently now.
This also leads to performance improvements as direct=true processes
do not need to load bash/go through the shell for startup.
Related RFC paketo-buildpacks/rfcs#136
Checklist