-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This buildpack can now use the tiny stack with reloadable processes #311
This buildpack can now use the tiny stack with reloadable processes #311
Conversation
I think the integration test is failing because of the |
Good catch @fg-j . "It worked on my machine!" Will push a fix in a minute. |
@fg-j it looks like using the tiny builder is causing further integration test problems. Should I pull it out? I admit that this integration test would have caught the logic in |
Hmm... I'm concerned that that integration test isn't passing. It should be, if the buildpack actually works with watchexec. This warrants more investigation. |
Grabbed the app locally and I get the following error
|
baaf184
to
f30404a
Compare
I've completely restored the integration test to its original state. Even though this has passed on my machine it's pretty flaky even locally. I wonder if there's some nuance of how the builder is pulled or used that may be an issue. A quick grep through paketo codebases indicates that integration tests don't usually set the builder, although smoke tests often do (for samples and builders). |
@joshuatcasey You might get a clearer idea of what's failing in the container on startup if you turn up the verbosity on watchexec |
This reverts commit f30404a.
- Also pull the tiny builder and tiny run image for integration tests
@ForestEckhardt would you mind taking a look at the PR? I think we've gotten past the integration test issue. |
Summary
This buildpack can now use the tiny stack with reloadable processes. While #296 addressed this, there was some logic in the
Detect
method that was not removed.See #296 (comment) for additional context.
Checklist