Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: don't award analytics data for messages not in l2 #1686

Merged
merged 1 commit into from
Feb 3, 2025
Merged

feat: don't award analytics data for messages not in l2 #1686

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions lib/pangea/events/models/representation_content_model.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ class PangeaRepresentation {
ChoreoRecord? choreo,
}) {
final List<OneConstructUse> uses = [];
final l2 = MatrixState.pangeaController.languageController.activeL2Code();
if (langCode != l2) return uses;

// missing vital info so return
if (event?.roomId == null && metadata?.roomId == null) {
Expand Down Expand Up @@ -151,14 +153,9 @@ class PangeaRepresentation {
final content = token.text.content;

if (choreo == null) {
final bool inUserL2 = langCode ==
MatrixState.pangeaController.languageController.activeL2Code();
final useType =
inUserL2 ? ConstructUseTypeEnum.wa : ConstructUseTypeEnum.unk;

uses.add(
OneConstructUse(
useType: useType,
useType: ConstructUseTypeEnum.wa,
lemma: token.pos,
form: token.text.content,
category: "POS",
Expand All @@ -170,7 +167,7 @@ class PangeaRepresentation {
for (final entry in token.morph.entries) {
uses.add(
OneConstructUse(
useType: useType,
useType: ConstructUseTypeEnum.wa,
lemma: entry.value,
form: token.text.content,
category: entry.key,
Expand All @@ -183,7 +180,7 @@ class PangeaRepresentation {
if (lemma.saveVocab) {
uses.add(
token.toVocabUse(
useType,
ConstructUseTypeEnum.wa,
metadata,
),
);
Expand Down
Loading