Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1949-changing-it-feedback #2088

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

sienna-sterling
Copy link
Collaborator

Thank you so much for your contribution to FluffyChat ❤️❤️❤️

Please make sure that your Pull Request meet the following acceptance criteria:

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

@sienna-sterling sienna-sterling linked an issue Mar 7, 2025 that may be closed by this pull request
@ggurdin
Copy link
Collaborator

ggurdin commented Mar 10, 2025

@sienna-sterling I added an update to use the existing choreo record to get the percent correct rather than storing them in a separate place. This way, there's one source of truth, and nothing extra has to be updated.

I think we should change the text feedback. Something like "that's not how I would say that" doesn't make sense if the translation itself is correct, but the percent is low because the user made any incorrect choices along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing IT Feedback
2 participants